[JDBC] Connection#createArray & Connection#createStruct
#2523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
chernser
requested review from
mzitnik and
Copilot
and removed request for
mzitnik
There was a problem hiding this comment.
Pull Request Overview
This PR implements Connection#createStruct and improves Connection#createArray to enhance JDBC SQL type support for ClickHouse arrays and tuples.
- Adds support for creating Struct objects from Tuple types
- Improves Array creation with better type handling and validation
- Refactors array encoding logic in PreparedStatement for better maintainability
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| jdbc-v2/src/main/java/com/clickhouse/jdbc/types/Struct.java | New Struct implementation for Tuple types |
| jdbc-v2/src/main/java/com/clickhouse/jdbc/types/Array.java | Enhanced Array constructor with better validation |
| jdbc-v2/src/main/java/com/clickhouse/jdbc/ConnectionImpl.java | Implements createStruct and improves createArrayOf methods |
| jdbc-v2/src/main/java/com/clickhouse/jdbc/PreparedStatementImpl.java | Refactored object encoding logic with better array/tuple handling |
| jdbc-v2/src/main/java/com/clickhouse/jdbc/internal/JdbcUtils.java | Updated array conversion utilities |
| jdbc-v2/src/test/java/com/clickhouse/jdbc/ConnectionTest.java | Added comprehensive tests for new functionality |
| Other files | Minor utility improvements and bug fixes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| @Override | ||
| public Object[] getAttributes(Map<String, Class<?>> map) throws SQLException { | ||
| return attributes; |
There was a problem hiding this comment.
The getAttributes(Map) method also returns a direct reference to the internal attributes array, allowing external modification. Consider returning a defensive copy: return attributes.clone();
Suggested change
| return attributes; | |
| return attributes.clone(); |
Copilot uses AI. Check for mistakes.
| final String tableName = "array_create_test"; | ||
| final String arrayType = "Array(Array(" + baseType + "))"; | ||
| try (Statement stmt = conn.createStatement()) { | ||
| stmt.executeUpdate("CREATE TABLE " +tableName + " (v1 " + arrayType + ") ENGINE MergeTree ORDER BY ()"); |
There was a problem hiding this comment.
[nitpick] String concatenation in SQL statements can be error-prone. Consider using String.format() or a StringBuilder for better readability: String.format("CREATE TABLE %s (v1 %s) ENGINE MergeTree ORDER BY ()", tableName, arrayType)
Suggested change
| stmt.executeUpdate("CREATE TABLE " +tableName + " (v1 " + arrayType + ") ENGINE MergeTree ORDER BY ()"); | |
| stmt.executeUpdate(String.format("CREATE TABLE %s (v1 %s) ENGINE MergeTree ORDER BY ()", tableName, arrayType)); |
Copilot uses AI. Check for mistakes.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Connection#createStructConnection#createArrayCloses #2412
Closes #2360
Checklist
Delete items not relevant to your PR: